Filesystem plugin separation of concerns#912
Merged
dOrgJelli merged 29 commits intoprealpha-devfrom Jun 24, 2022
Merged
Conversation
…gin-separation-of-concerns
nerfZael
requested changes
Jun 11, 2022
…gin-separation-of-concerns
…tem ecoding enum, implement additional tests
…gin-separation-of-concerns
pileks
requested review from
Niraj-Kamdar,
dOrgJelli,
krisbitney and
namesty
as code owners
2 tasks
…gin-separation-of-concerns
…gin-separation-of-concerns
nerfZael
requested changes
Jun 22, 2022
Contributor
|
After talking with @dOrgJelli we decided file system should be two words, so: |
pileks
commented
Jun 23, 2022
| @@ -0,0 +1,46 @@ | |||
| import { Filesystem_Encoding, Filesystem_EncodingEnum } from "../wrap"; | |||
|
|
|||
| export const filesystemEncodingToBufferEncoding = ( | |||
Contributor
Author
There was a problem hiding this comment.
Would we then want to export default?
…gin-separation-of-concerns
…gin-separation-of-concerns
nerfZael
previously approved these changes
Jun 23, 2022
dOrgJelli
previously approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially closes #622 and #714 (filesystem part)
After discussion with @nerfZael the following was done:
filesystem-like pluginsuri-resolverinterface implementation fromfilesystemplugin into its ownfs-uri-resolverpluginfilesystemplugin which implements thefilesysteminterface@web3api/*-interfacepattern and added it to the main build commandAdvice/feedback would be much appreciated!