feat(cli): improve tests for create command#959
Conversation
There was a problem hiding this comment.
Hey Niraj thanks for start a tackle on this 🙏
I was thinking that this is not the approach we want to take if we want to close #907 - I think instead we should create a new file in __tests__/unit/ folder named create.spec.ts and basically try to run the functions from there and check if the behavior is the expected.
For example, I thought that we can follow these approaches:
tj/commander.js#438 (comment)
tj/commander.js#1565 (comment)
and execute every method of instance?
Another approach we can take is to (talking from the context of create tests) execute the run function and see if it indeed creates a folder for example
Note that the objective of these approaches is to be able to take up our code coverage, as you mentioned before :-D
|
@cbrzn I'd still keep e2e tests, we just need to add unit tests. |
That's correct! I would remove the |
dOrgJelli
left a comment
There was a problem hiding this comment.
This is really nice @Niraj-Kamdar 👏
|
Also IMO @cbrzn @Niraj-Kamdar I think this fully tests the |
Uh oh!
There was an error while loading. Please reload this page.