Skip to content

feat(tui): show lock indicator for locked Milltime time entries#97

Merged
alxhall merged 1 commit intoponbac:masterfrom
alxhall:feature/locked-entries
Mar 6, 2026
Merged

feat(tui): show lock indicator for locked Milltime time entries#97
alxhall merged 1 commit intoponbac:masterfrom
alxhall:feature/locked-entries

Conversation

@alxhall
Copy link
Collaborator

@alxhall alxhall commented Mar 2, 2026

This pull request introduces support for "locked" time entries by adding an attestation/lock level to entries, preventing editing or deletion of locked items, and updating the UI to visually indicate locked entries. The changes ensure that entries with an attestation level (week or month) cannot be modified, and provide clear feedback to users when such actions are attempted.

Entry Locking and Attestation Support

  • Added a new AttestLevel enum to represent the attestation/lock status of a time entry, with methods for conversion and lock checking. The TimeEntry struct now includes an attest_level field, and entries default to unlocked unless specified.

Edit and Delete Guarding

  • Updated edit and delete logic in App and runtime view handlers to check if the focused entry is locked before allowing modifications. If locked, a status message is shown and the action is blocked.
    User Feedback

  • Added status messages for locked entry edit and delete attempts, providing immediate feedback to users when such actions are not permitted.

UI Updates

  • Updated the display row logic to show a red "⊘" symbol for locked entries, taking precedence over the warning symbol for overlapping entries, to clearly indicate locked status in the UI.

@vercel
Copy link

vercel bot commented Mar 2, 2026

@alxhall is attempting to deploy a commit to the ponbac's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@ponbac
Copy link
Owner

ponbac commented Mar 2, 2026

@codex

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@alxhall alxhall merged commit afeaf10 into ponbac:master Mar 6, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants