fix: require Sendblue webhook secret#2
Open
danielz1z wants to merge 1 commit into
Open
Conversation
|
@danielz1z is attempting to deploy a commit to the Midday Labs AB Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Thanks for the project. I kept this PR narrow: it only aligns the incoming webhook parser with Sendblue's documented signing-secret header and rejects unsigned webhook requests.\n\nI verified locally with Bun 1.3.12: test, lint, typecheck, and the filtered API build all pass. GitHub Actions is currently waiting for maintainer approval on the forked PR, and the Vercel preview checks show authorization required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sb-signing-secretheaderTest Plan
npm exec --yes bun@1.3.12 -- test apps/api/src/__tests__/sendblue.test.tsnpm exec --yes bun@1.3.12 -- run testnpm exec --yes bun@1.3.12 -- run lintnpm exec --yes bun@1.3.12 -- run typecheck./node_modules/.bin/turbo build --filter=@caltext/api