Skip to content

Revisit SSL context fallback behavior when system CA store is unavailable #92

@SeanTAllen

Description

@SeanTAllen

SSLContextFactory attempts to create a verified SSL context via set_authority(None)?, which asks OpenSSL to use the default system CA store. When the CA store isn't discoverable (e.g. WSL2 without ca-certificates), this fails. Currently we fall back to set_client_verify(false), matching what ponylang/http's HTTPClient did silently.

This means every API call from the library — not just examples — silently downgrades to unverified HTTPS when no CA store is found. That's fine for local development but worth thinking through for a library that sends auth tokens over the wire.

Questions to consider:

  • Should the library warn or fail loudly when falling back to unverified SSL?
  • Should this be configurable via Credentials or a separate option?
  • Is the silent fallback actually the right default for a GitHub API client?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions