Fix always-true redirect status check in HTTP handlers#53
Merged
SeanTAllen merged 1 commit intomainfrom Feb 8, 2026
Merged
Conversation
The condition `(_status != 301) or (_status != 307)` is a tautology — a value can't be both 301 and 307 simultaneously, so one side is always true. Changed to `and` so the check correctly means "neither 301 nor 307." Closes #47
ponylang-main
added
the
discuss during sync
SeanTAllen
added
the
changelog - fixed
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
finished()method in bothJsonRequesterHandlerandPaginatedJsonRequesterHandlerhad(_status != 301) or (_status != 307), which is always true. Changedortoandso redirect responses aren't incorrectly reported as errors.Closes #47