Add QueryParams for URL query string construction#59
Merged
SeanTAllen merged 1 commit intomainfrom Feb 8, 2026
Merged
Conversation
ponylang-main
added
the
discuss during sync
Extracts query parameter building into a reusable QueryParams primitive with proper RFC 3986 percent-encoding. Previously, GetRepositoryIssues built query strings via manual concatenation without encoding, meaning values with special characters would produce malformed URLs. QueryParams encodes all characters except the RFC 3986 unreserved set (A-Z, a-z, 0-9, -, ., _, ~) using self-contained logic rather than the http library's URLEncode, which uses URLPartQuery semantics that leave & and = unencoded — inappropriate for query parameter values. Includes example-based and property-based tests (first PonyCheck usage in the project).
SeanTAllen
force-pushed
the
add-query-params
branch
from
0e84109 to
49528c9
Compare
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueryParamsprimitive in therequestpackage for building URL query strings with proper RFC 3986 percent-encodingGetRepositoryIssuesandRepository.get_issues()to useQueryParamsinstead of manual string concatenation (which had no URL encoding)Addresses the "Query parameter support" item from discussion #45.