Port HTTP transport from ponylang/http to ponylang/courier#91
Merged
SeanTAllen merged 1 commit intomainfrom Mar 2, 2026
Merged
Port HTTP transport from ponylang/http to ponylang/courier#91SeanTAllen merged 1 commit intomainfrom
SeanTAllen merged 1 commit intomainfrom
Conversation
Replace the HTTP handler factory pattern (25 types: 8 requesters + 8 handler factories + 8 handlers + RequestFactory) with courier's actor-based connection model (6 types: 4 request actors + 1 SSL factory + 1 shared interface). Each API call creates a short-lived actor owning an HTTPClientConnection. Consolidation by response pattern: POST+PATCH share JsonRequester (differ by method/expected status), DELETE+PUT share NoContentRequester, paginated+search share LinkedJsonRequester via a LinkedResultReceiver interface. All actors close their connection in on_response_complete so the runtime exits promptly. SSLContextFactory tries the system CA store for verified HTTPS; when unavailable it falls back to unverified SSL, matching the old HTTPClient behavior. Breaking change: Credentials.auth changes from net.TCPConnectAuth to lori.TCPConnectAuth. Authorization header moves from legacy "token" format to "Bearer" format (GitHub accepts both). Public API is otherwise preserved — all operation primitives, model classes, OO convenience methods, and pagination work the same way.
48d880f to
6043cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the HTTP handler factory pattern (25 types: 8 requesters + 8 handler factories + 8 handlers + RequestFactory) with courier's actor-based connection model (6 types: 4 request actors + 1 SSL factory + 1 shared interface).
Each API call creates a short-lived actor owning an HTTPClientConnection. Consolidation by response pattern: POST+PATCH share JsonRequester (differ by method/expected status), DELETE+PUT share NoContentRequester, paginated+search share LinkedJsonRequester via a LinkedResultReceiver interface.
Breaking change:
Credentials.authchanges fromnet.TCPConnectAuthtolori.TCPConnectAuth. Authorization header moves from legacytokenformat toBearerformat (GitHub accepts both).Public API is otherwise preserved — all operation primitives, model classes, OO convenience methods, and pagination work the same way.