Repository navigation
Consider format-specific timestamp decode methods #61
SeanTAllen
started this conversation in
Research
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
While planning the implementation of #13 (format-specific bin/ext/str decoding), we noticed a similar gap in the timestamp family.
The encoder has format-specific
timestamp_32,timestamp_64, andtimestamp_96methods, but the decoder only has the compacttimestamp()method, which uses anifchain to dispatch across the three wire formats (fixext_4, fixext_8, ext_8). The same performance argument from #13 applies here — callers who know the exact timestamp wire format pay for unnecessary dispatch.That said, timestamps are a higher-level concept layered on top of ext wire formats (they use ext format bytes with ext_type
0xFF), so they're arguably a different category than the "raw format-specific decode" methods in #13. Some questions worth considering:timestamp_32,timestamp_64,timestamp_96) be added for symmetry with the encoder?ifchain negligible given the data sizes involved?Kicked out from the #13 planning process to consider separately.
All reactions