Merged
Conversation
Expose the PostgreSQL ReadyForQuery status byte to users via a new TransactionStatus union type and pg_transaction_status callback on SessionStatusNotify. The callback fires after every query cycle completes (including the initial ready signal after authentication), reporting TransactionIdle, TransactionInBlock, or TransactionFailed. The three boolean methods on _ReadyForQueryMessage (idle(), in_transaction_block(), failed_transaction()) are replaced by a single transaction_status() method that returns the public TransactionStatus type. Non-breaking: the callback has a default no-op body, so existing SessionStatusNotify implementations are unaffected. Design: #102
SeanTAllen
added
the
changelog - added
ponylang-main
added
the
discuss during sync
The example demonstrates the pg_transaction_status callback, not transactions themselves.
Remove table scaffolding that wasn't relevant to the callback being demonstrated. The example now just sends BEGIN and COMMIT to show the status changing from idle to in-transaction and back.
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the PostgreSQL ReadyForQuery status byte to users via a new
TransactionStatusunion type andpg_transaction_statuscallback onSessionStatusNotify.The callback fires after every query cycle completes (including the initial ready signal after authentication), reporting
TransactionIdle,TransactionInBlock, orTransactionFailed. Non-breaking — the callback has a default no-op body.Replaces the three internal boolean methods on
_ReadyForQueryMessage(idle(),in_transaction_block(),failed_transaction()) with a singletransaction_status()method returning the public type.Design: #102