Conversation
Parse NotificationResponse messages and deliver them to users via a new pg_notification callback on SessionStatusNotify. Previously these messages were returned as _SkippedMessage and silently ignored. The parser uses the isolated-payload pattern (buffer.block + separate Reader) matching the approach used by all other variable-length message parsers in the codebase, rather than reading directly from the shared buffer as originally proposed in the design. New public API: Notification val class (channel, payload, pid) and pg_notification behavior with default no-op body (non-breaking). Design: #103
SeanTAllen
added
the
changelog - added
ponylang-main
added
the
discuss during sync
Integration test belongs with other notification tests for cohesion. Remove LISTEN/NOTIFY from unsupported features list in README.
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse NotificationResponse messages and deliver them via a new
pg_notificationcallback onSessionStatusNotify. Previously these messages were silently ignored.New public API:
Notificationval class withchannel,payload, andpidfieldspg_notification(session, notification)behavior onSessionStatusNotifywith default no-op body (non-breaking)The parser uses the isolated-payload pattern (
buffer.block+ separateReader) matching all other variable-length message parsers, per the review finding posted on the design discussion.Design: #103