Guard against integer overflow on server-supplied message lengths#220
Merged
SeanTAllen merged 1 commit intomainfrom Apr 14, 2026
Merged
Guard against integer overflow on server-supplied message lengths#220SeanTAllen merged 1 commit intomainfrom
SeanTAllen merged 1 commit intomainfrom
Conversation
Closes #217. Companion to #211. USize addition wraps just like USize subtraction does. On 32-bit USize targets a server-declared length near `U32.max` could wrap `payload_size + 4 + 1` to a small value and slip a bogus zero- payload acknowledgement past the buffer-size check. Same flavor of bug as #211, same flavor of fix — validate the arithmetic so wrap surfaces as a protocol violation directly. CI runs lp64, so the regression can only be reasoned about analytically here; the ilp32 test branch is retained for whenever a 32-bit Pony target lands.
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to #211. On 32-bit
USizetargets a server-declared length nearU32.maxcould wrappayload_size + 4 + 1to a small value, slipping a bogus zero-payload acknowledgement past the buffer-size check. The fix is the same flavor as #215 — use partial arithmetic at the site so the wrap surfaces as a protocol violation directly.CI runs lp64, so the new test's ilp32 branch can't be exercised here; the counterfactual was walked through analytically and is documented in the test's docstring.
Closes #217.