Validate DataRow column length before buffered read#225
Merged
SeanTAllen merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
The match against -1 covers the NULL marker, but column lengths in 0x80000000..0xFFFFFFFE represent invalid signed Int32 values that fell through to reader.block() unchecked. Same flavor as #211 — make the validation explicit at the parse site rather than relying on a downstream read failure. Closes #216.
Contributor
|
Hi @SeanTAllen, The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be: Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #216.
_data_rowmatched the column length against-1(NULL) and0, but column lengths in0x80000000..0xFFFFFFFE— invalid signedInt32values — fell through toreader.block()without validation. The huge length errored at the buffered read and routed through the protocol-violation path, so no observable behavior changes; this makes the validation explicit at the parse site. Same flavor as #211.Note on the test: both code paths (with and without the explicit
if) error externally —reader.block()will reject any bogus length we can practically construct in a test. The test is therefore a behavioral regression test for "parser rejects malformed column length", not a strict counterfactual for the newif. Flagging in case you'd rather drop the test — I think keeping it is the right call but it's a judgment call.