Process query cycle messages synchronously to prevent double-delivery#69
Merged
SeanTAllen merged 1 commit intomainfrom Feb 9, 2026
Merged
Conversation
_ResponseMessageParser previously processed one message per call and yielded via _process_again between each message. This created a window where close() could execute between ErrorResponse and ReadyForQuery, causing on_shutdown to deliver SessionClosed to a receiver that already received the error — a double-delivery of pg_query_failed. Now loops synchronously within a query cycle, yielding only after ReadyForQuery. If a callback triggers shutdown, on_shutdown clears the read buffer, causing the next parse to return None and exit the loop naturally. Closes #68
SeanTAllen
added
the
changelog - fixed
ponylang-main
added
the
discuss during sync
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_ResponseMessageParserpreviously processed one message per call and yielded via_process_again()between each message. This created a window whereclose()could execute betweenErrorResponseandReadyForQuery, causingon_shutdownto deliverSessionClosedto a receiver that already received the error.Now loops synchronously within a query cycle, yielding only after
ReadyForQuery. If a callback triggers shutdown,on_shutdownclears the read buffer, causing the next parse to returnNoneand exit the loop naturally.Closes #68