Skip to content

[MERGE] dev to main#165

Merged
Iwantcod merged 2 commits into
mainfrom
dev
Mar 11, 2026
Merged

[MERGE] dev to main#165
Iwantcod merged 2 commits into
mainfrom
dev

Conversation

@Iwantcod
Copy link
Copy Markdown
Member

@Iwantcod Iwantcod commented Mar 11, 2026

개요

관련 BackLog

Resolves: (Backlog Number, ...)

PR 유형

  • 새로운 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
  • 코드 리팩토링
  • 주석 추가 및 수정
  • 문서 수정
  • 테스트 추가, 테스트 리팩토링
  • 빌드 부분 혹은 패키지 매니저 수정
  • 파일 혹은 폴더명 수정
  • 파일 혹은 폴더 삭제

PR Checklist

  • 커밋 메시지 컨벤션에 맞게 작성했습니다.
  • 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the alarm notification channel used for immediate block policy updates to ensure notifications are sent through the proper channel.

@Iwantcod Iwantcod requested a review from pjh813 March 11, 2026 16:34
@Iwantcod Iwantcod self-assigned this Mar 11, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 11, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ea8e1613-1495-4ae6-a514-5fc9c403f656

📥 Commits

Reviewing files that changed from the base of the PR and between b649125 and 4d7284e.

📒 Files selected for processing (1)
  • src/test/java/com/pooli/policy/service/UserPolicyServiceImplTest.java

📝 Walkthrough

Walkthrough

This PR updates a test expectation in UserPolicyServiceImplTest.java, changing the expected alarm code from POLICY_CHANGE to POLICY_LIMIT in the updateImmediateBlockPolicy_success test case. A clarifying comment is added to document that block policy alarms use the POLICY_LIMIT channel.

Changes

Cohort / File(s) Summary
Test Update
src/test/java/com/pooli/policy/service/UserPolicyServiceImplTest.java
Updated updateImmediateBlockPolicy_success test expectation: changed expected AlarmCode from POLICY_CHANGE to POLICY_LIMIT with explanatory comment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • Dev를 main으로 merge #160 — Modifies the same test case updateImmediateBlockPolicy_success in UserPolicyServiceImplTest, but changes the expected AlarmCode in the opposite direction.

Suggested labels

test

Suggested reviewers

  • pjh813
  • Misu0616
  • ms-0o0

Poem

🐰 A test hops with updated cheer,
AlarmCode shifts crystal clear,
From POLICY_CHANGE to POLICY_LIMIT's way,
Block policies align today! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Iwantcod Iwantcod merged commit e076abc into main Mar 11, 2026
2 of 3 checks passed
This was referenced Mar 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants