Skip to content

Feat/225 swagger permission seunghyun#18

Merged
Misu0616 merged 1 commit into
feat/225-swagger-docsfrom
feat/225-swagger-permission-seunghyun
Feb 23, 2026
Merged

Feat/225 swagger permission seunghyun#18
Misu0616 merged 1 commit into
feat/225-swagger-docsfrom
feat/225-swagger-permission-seunghyun

Conversation

@hyuuuun
Copy link
Copy Markdown
Contributor

@hyuuuun hyuuuun commented Feb 23, 2026

개요

permissionDto 생성자 private으로 변경

관련 BackLog

Resolves: (Backlog Number, ...)

PR 유형

  • [] 새로운 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
  • 코드 리팩토링
  • 주석 추가 및 수정
  • 문서 수정
  • 테스트 추가, 테스트 리팩토링
  • 빌드 부분 혹은 패키지 매니저 수정
  • 파일 혹은 폴더명 수정
  • 파일 혹은 폴더 삭제

PR Checklist

  • 커밋 메시지 컨벤션에 맞게 작성했습니다.
  • 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).

Summary by CodeRabbit

Release Notes

  • New Features

    • Permission management API with full create, read, update, and delete operations
    • Member permission assignment and management endpoints
    • Role transfer capability for family representatives
    • Integrated API documentation interface
  • Chores

    • Added API documentation library dependency
    • Configured application security and properties

@hyuuuun hyuuuun requested a review from Misu0616 February 23, 2026 00:38
@hyuuuun hyuuuun self-assigned this Feb 23, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 23, 2026

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Walkthrough

This PR introduces a complete permission management module featuring three REST controllers for handling permissions, member permissions, and role transfers. It includes Spring Security configuration, OpenAPI documentation setup, multiple data transfer objects, and application configuration properties to support the new endpoints.

Changes

Cohort / File(s) Summary
Configuration & Build
.gitignore, build.gradle, src/main/resources/application.yaml
Added metadata to STS gitignore, springdoc-openapi-starter-webmvc-ui dependency, and comprehensive Spring Boot application configuration for datasource, security, and logging.
Spring Configuration
src/main/java/com/pooli/common/config/OpenApiConfig.java, src/main/java/com/pooli/common/config/SecurityConfig.java
OpenAPI bean configuration for API documentation with metadata, and SecurityConfig enabling CSRF protection bypass with permissive access for Swagger UI and permit-all authorization.
Permission Controllers
src/main/java/com/pooli/permission/controller/MemberPermissionController.java, src/main/java/com/pooli/permission/controller/PermissionController.java, src/main/java/com/pooli/permission/controller/RoleController.java
Three REST controllers providing endpoints for member permission retrieval/updates, permission CRUD operations, and representative role transfers. Controllers return mock/hardcoded data with builder-pattern DTOs.
Request DTOs
src/main/java/com/pooli/permission/domain/dto/request/MemberPermissionUpsertReqDto.java, src/main/java/com/pooli/permission/domain/dto/request/PermissionReqDto.java
New request objects for upserting member permissions and creating/updating permissions, annotated with Lombok and Swagger schema metadata.
Response DTOs
src/main/java/com/pooli/permission/domain/dto/response/*
Six response DTOs for permission operations: MemberPermissionListResDto, MemberPermissionResDto, PermissionListResDto, PermissionResDto, RepresentativeRoleTransferResDto, and SimpleMessageResDto. All use Lombok for boilerplate and Swagger annotations for documentation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Permissions bloom like clover in spring,
Roles and member gates, a security thing!
With Swagger docs dancing and DTOs neat,
Our API's now ready—oh what a treat!
Permissions granted, hopping complete! 🔐✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Feat/225 swagger permission seunghyun' refers to a real part of the changeset (adding Swagger/OpenAPI documentation for permission endpoints), but it is overly broad and uses a Jira ticket reference with a developer name, which is not a clear summary of the main change. Consider a more descriptive title like 'Add Swagger/OpenAPI configuration and permission endpoints' that clearly conveys what was added without Jira references or developer names.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/225-swagger-permission-seunghyun

Comment @coderabbitai help to get the list of available commands and usage tips.

@hyuuuun hyuuuun added the refactor 리팩토링 label Feb 23, 2026
@hyuuuun hyuuuun changed the base branch from main to feat/225-swagger-docs February 23, 2026 00:39
@Misu0616
Copy link
Copy Markdown
Contributor

관련 사항 확인했습니다 req, res에 모두 동일하게 적용되는지는 추후 논의를 통해 확정하면 될 것 같습니다

@Misu0616 Misu0616 merged commit 4ec8466 into feat/225-swagger-docs Feb 23, 2026
1 check passed
@coderabbitai coderabbitai Bot mentioned this pull request Feb 23, 2026
13 tasks
@ms-0o0 ms-0o0 deleted the feat/225-swagger-permission-seunghyun branch February 27, 2026 05:28
@coderabbitai coderabbitai Bot mentioned this pull request Mar 4, 2026
13 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Mar 11, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants