Dev to main

[Iwantcod]

개요

앱별 정책 활성화 토글 api 요청 처리 로직 내 파라미터 null 되는 문제 해결

관련 BackLog

Resolves: (Backlog Number, ...)

PR 유형

• 새로운 기능 추가
• 버그 수정
• CSS 등 사용자 UI 디자인 변경
• 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
• 코드 리팩토링
• 주석 추가 및 수정
• 문서 수정
• 테스트 추가, 테스트 리팩토링
• 빌드 부분 혹은 패키지 매니저 수정
• 파일 혹은 폴더명 수정
• 파일 혹은 폴더 삭제

PR Checklist

• 커밋 메시지 컨벤션에 맞게 작성했습니다.
• 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).

Summary by CodeRabbit

• Bug Fixes
  • Fixed policy creation alarms to correctly reference the newly created policy's line ID instead of a previous policy reference. This ensures alarm notifications are properly associated with the intended policy.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b89fdd69-3d14-4ffb-85ca-c56132edc37e

📥 Commits

Reviewing files that changed from the base of the PR and between 3eca48f and 6f09b10.

📒 Files selected for processing (2)

• src/main/java/com/pooli/policy/service/UserPolicyServiceImpl.java
• src/test/java/com/pooli/policy/service/UserPolicyServiceImplTest.java

---

📝 Walkthrough

Walkthrough

Bug fix in app policy creation path where two alarm invocations now source the lineId from the newly created AppPolicy instead of the existing AppPolicy. Corresponding test updated with additional alarm verifications.

Changes

Cohort / File(s)	Summary
App Policy Service src/main/java/com/pooli/policy/service/UserPolicyServiceImpl.java	Fixed alarm invocations for POLICY_CREATE_APP_USAGE_LIMIT and POLICY_CREATE_DATA_SPEED_LIMIT to use newAppPolicy.getLineId() instead of appPolicy.getLineId().
Service Test src/test/java/com/pooli/policy/service/UserPolicyServiceImplTest.java	Added alarm emission verifications for new app policy creation and adjusted AppPolicyResDto test setup.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

bug

Suggested reviewers

• pjh813
• Misu0616
• hyuuuun

Poem

🐰 A lineId fix hops through the code,
From old to new, the alarm's abode,
NewAppPolicy claims what's rightfully theirs,
Tests verify with utmost care! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The PR title 'Dev to main' is vague and generic, failing to convey the actual change being made (fixing null line_id in alarm history for app policy creation).	Use a more descriptive title that reflects the actual fix, such as 'Fix null line_id in alarm history for app policy creation' or 'Use newAppPolicy lineId for alarm invocations in policy toggle.'

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Misu0616]

확인 완료