Dev

[ms-0o0]

개요

알람 처리 cpu 과부하 덜하게끔 로직 변경

관련 BackLog

Resolves: (Backlog Number, ...)

PR 유형

• 새로운 기능 추가
• 버그 수정
• CSS 등 사용자 UI 디자인 변경
• 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
• 코드 리팩토링
• 주석 추가 및 수정
• 문서 수정
• 테스트 추가, 테스트 리팩토링
• 빌드 부분 혹은 패키지 매니저 수정
• 파일 혹은 폴더명 수정
• 파일 혹은 폴더 삭제

PR Checklist

• 커밋 메시지 컨벤션에 맞게 작성했습니다.
• 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).

Summary by CodeRabbit

• Refactor
  • Optimized notification delivery system for bulk target types (ALL, OWNER, MEMBER) to streamline processing and improve efficiency.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 827d5c4b-7b61-4203-bd92-8973f0542b92

📥 Commits

Reviewing files that changed from the base of the PR and between 458a433 and 82f5d5b.

📒 Files selected for processing (2)

• src/main/java/com/pooli/notification/service/AlarmHistoryServiceImpl.java
• src/test/java/com/pooli/notification/service/AlarmHistoryServiceImplTest.java

---

📝 Walkthrough

Walkthrough

The notification-sending logic in AlarmHistoryServiceImpl is refactored to directly invoke specific mapper methods for ALL, OWNER, and MEMBER target types, replacing the previous approach of collecting targetLineIds and performing a separate batched insert. Test expectations are updated accordingly.

Changes

Cohort / File(s)	Summary
Service Implementation src/main/java/com/pooli/notification/service/AlarmHistoryServiceImpl.java	Refactored sendNotification method to directly call insertNotificationAll, insertNotificationOwner, or insertNotificationMember mapper methods instead of collecting targetLineIds and performing a subsequent batchInsert. DIRECT target type logic unchanged.
Test Updates src/test/java/com/pooli/notification/service/AlarmHistoryServiceImplTest.java	Updated ALL-target notification test flow to expect insertNotificationAll(String, String) calls instead of insertNotificationAlarms(List, String, String). Removed stub for notificationLineMapper.findAllLineIds().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Suggested reviewers

• hyuuuun
• hyeonRS

Poem

🐰 Direct paths now lead the way,
No more batches left to stray,
Mapper calls sing clear and true,
Simpler code—a cleaner brew!
Tests confirm the swift refrain,
Hopping faster through the lane! 🥕

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}