Skip to content

fix : remainingData 보이는 수치 수정#307

Closed
hyuuuun wants to merge 1 commit into
mainfrom
fix-remaining-data
Closed

fix : remainingData 보이는 수치 수정#307
hyuuuun wants to merge 1 commit into
mainfrom
fix-remaining-data

Conversation

@hyuuuun
Copy link
Copy Markdown
Contributor

@hyuuuun hyuuuun commented Mar 19, 2026

개요

관련 BackLog

Resolves: (Backlog Number, ...)

PR 유형

  • 새로운 기능 추가
  • 버그 수정
  • CSS 등 사용자 UI 디자인 변경
  • 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
  • 코드 리팩토링
  • 주석 추가 및 수정
  • 문서 수정
  • 테스트 추가, 테스트 리팩토링
  • 빌드 부분 혹은 패키지 매니저 수정
  • 파일 혹은 폴더명 수정
  • 파일 혹은 폴더 삭제

PR Checklist

  • 커밋 메시지 컨벤션에 맞게 작성했습니다.
  • 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Updated shared pool remaining data calculation to use actual traffic-based resolution, providing more accurate and real-time reporting of available shared pool resources across family accounts.
  • Tests

    • Updated service tests to reflect and validate the improved calculation methodology.

@hyuuuun hyuuuun requested review from Iwantcod and pjh813 March 19, 2026 21:11
@hyuuuun hyuuuun self-assigned this Mar 19, 2026
@github-actions
Copy link
Copy Markdown

정책 위반: main에는 dev에서만 PR이 가능합니다. 이 PR은 자동으로 닫습니다.

@github-actions github-actions Bot closed this Mar 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 19, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b178c7b7-90df-4354-803c-dfee0bba1108

📥 Commits

Reviewing files that changed from the base of the PR and between cd13f84 and 62e39d8.

📒 Files selected for processing (2)
  • src/main/java/com/pooli/family/service/FamilySharedPoolsService.java
  • src/test/java/com/pooli/family/service/FamilySharedPoolsServiceTest.java

📝 Walkthrough

Walkthrough

The getSharedPoolMain method in FamilySharedPoolsService now computes shared pool remaining data using trafficRemainingBalanceQueryService.resolveSharedActualRemaining() instead of the previous monthly calculation approach. The corresponding test setup and assertions were updated to reflect this new resolution logic.

Changes

Cohort / File(s) Summary
Service Implementation
src/main/java/com/pooli/family/service/FamilySharedPoolsService.java
Updated getSharedPoolMain() to compute sharedPoolRemainingData via trafficRemainingBalanceQueryService.resolveSharedActualRemaining(familyId, domain.getPoolRemainingData()) instead of resolveFamilyMonthlySharedPoolRemaining(familyId).
Test Updates
src/test/java/com/pooli/family/service/FamilySharedPoolsServiceTest.java
Modified getSharedPoolMain_success test setup to mock the new actual-remaining resolution method. Updated @DisplayName to reflect "actual remaining" and adjusted expected remaining value assertion from 1_150_000L to 1_350_000L.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Dev #303: Switches remaining-data resolution in FamilySharedPoolsService to use trafficRemainingBalanceQueryService for a different method.
  • Dev #258: Directly replaces monthly-remaining logic with TrafficRemainingBalanceQueryService.resolveSharedActualRemaining and updates related tests.

Suggested labels

bug

Suggested reviewers

  • hyeonRS
  • pjh813
  • Misu0616

Poem

🐰 Hop hop, the pools now see true,
Actual remaining breaks through,
No more monthly guessing games,
Traffic whispers the real claims!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-remaining-data
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

정책 위반: main에는 dev에서만 PR이 가능합니다. 이 PR은 자동으로 닫습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant