Dev

[hyuuuun]

개요

관련 BackLog

Resolves: (Backlog Number, ...)

PR 유형

• 새로운 기능 추가
• 버그 수정
• CSS 등 사용자 UI 디자인 변경
• 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
• 코드 리팩토링
• 주석 추가 및 수정
• 문서 수정
• 테스트 추가, 테스트 리팩토링
• 빌드 부분 혹은 패키지 매니저 수정
• 파일 혹은 폴더명 수정
• 파일 혹은 폴더 삭제

PR Checklist

• 커밋 메시지 컨벤션에 맞게 작성했습니다.
• 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).

Summary by CodeRabbit

• Bug Fixes
  • Improved accuracy of shared pool remaining data by switching from monthly-calculated estimates to real-time actual balance calculations, ensuring users receive current and precise information.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7ba73e77-e406-4760-9cad-b3cdf67a58e6

📥 Commits

Reviewing files that changed from the base of the PR and between cd13f84 and c24baee.

📒 Files selected for processing (2)

• src/main/java/com/pooli/family/service/FamilySharedPoolsService.java
• src/test/java/com/pooli/family/service/FamilySharedPoolsServiceTest.java

---

📝 Walkthrough

Walkthrough

The FamilySharedPoolsService.getSharedPoolMain() method now retrieves the shared pool remaining data from a real-time actual remaining balance instead of a monthly calculation. The test is updated to mock the new data source and verify the correct expected value.

Changes

Cohort / File(s)	Summary
Service Implementation src/main/java/com/pooli/family/service/FamilySharedPoolsService.java	Replaced monthly-calculated remaining amount (resolveFamilyMonthlySharedPoolRemaining) with actual shared remaining balance from trafficRemainingBalanceQueryService.resolveSharedActualRemaining() in the getSharedPoolMain() method.
Service Test src/test/java/com/pooli/family/service/FamilySharedPoolsServiceTest.java	Updated test mocks to stub resolveSharedActualRemaining() instead of monthly-calculation dependencies; adjusted expected remaining value from 1_150_000L to 1_350_000L to reflect actual remaining calculation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Dev #258: Directly modifies FamilySharedPoolsService to use TrafficRemainingBalanceQueryService with the same remaining-data calculation switch.
• [MERGE] Dev to Main #173: Updates FamilySharedPoolsService with related mapper and DTO changes for family shared pool usage data.
• Dev #303: Applies similar actual-remaining data resolution pattern to FamilySharedPoolsService for individual pool operations.

Suggested labels

bug

Suggested reviewers

• hyeonRS
• Misu0616
• pjh813

Poem

🐰 Hops with glee, from monthly dreams so bright,
To actual balances, real-time and true,
No more delays in the pooling light,
Fresh data flows through, in a morning dew! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}