fix: #302 Environment.type で ENV['RACK_ENV'] を優先#315
Merged
Conversation
ginseng-core の Ginseng::Environment.type は Config.instance['/environment'] のみを読み、ENV['RACK_ENV'] を見ない。cure-api の application.yaml に /environment キーが無いため、rc.d で RACK_ENV=production を渡しても Puma は development モードで起動していた(エラー時に詳細スタックが クライアントに公開される問題の遠因)。 cure-api 側の局所対処として ENV['RACK_ENV'] を優先する override を入れる。 ginseng-core 本体の根本対処は ginseng-core #479 で別途。 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cure-api 側の局所 override で `Environment.type` に ENV['RACK_ENV'] を読ませる。v3.0.3 として小修正リリースする。
経緯
#302 の根本原因が判明:
修正
app/lib/cure_api/environment.rb で `type` を override:
```ruby
def self.type
env = ENV['RACK_ENV']
return env.to_sym if env && !env.empty?
return super
end
```
優先順位: ENV['RACK_ENV'] → Config['/environment'] → :development
ginseng-core 本体の対処
ginseng-core #479 で起票済み。横断的影響評価が必要なため別作業とする。本 PR は cure-api 局所対処にとどめる。
Test plan
Closes #302
🤖 Generated with Claude Code