Update wgpu to a commit that fixes use on Nvidia drivers#98
Merged
Conversation
This can be tested with something like `VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/nvidia_icd.json cargo run -p tour --features iced/wgpu`. On Nvidia I'm seeing a flood of `Suboptimal present of frame` warnings. So some improvement may still be needed here. But if it doesn't regress behavior on other hardware, that seems like an improvement over freezing.
|
Is it 20fda69 specifically that has an important fix? I have just been adding a patch for wgpu to all of the projects that I plan on removing when there is a release with your fix, but I used faed98b45cdc105df78b110e3fd6ca3eef36efc7 |
Member
Author
|
20fda69 is just the latest commit to wgpu. Which seems as good an option as any. Generally iced-based apps shouldn't depend on wgpu except through iced, so it seems best to change the dep here, in one place (well 2; also glyphon), rather than adding |
wash2
approved these changes
Feb 6, 2024
ids1024
added a commit
to pop-os/libcosmic
that referenced
this pull request
Feb 6, 2024
Update to include pop-os/iced#98.
mmstick
pushed a commit
to pop-os/libcosmic
that referenced
this pull request
Feb 6, 2024
Update to include pop-os/iced#98.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be tested with something like
VK_ICD_FILENAMES=/usr/share/vulkan/icd.d/nvidia_icd.json cargo run -p tour --features iced/wgpu.On Nvidia I'm seeing a flood of
Suboptimal present of framewarnings. So some improvement may still be needed here. But if it doesn't regress behavior on other hardware, that seems like an improvement over freezing.