No hint on first opened window when using Smart Gaps

[pesader]

(1) Issue/Bug Description:

When Smart Gaps is turned on, the first opened window doesn't get hinted when it gets the focus (given that two or more windows are in the same workspace).
Also, when the last window left in a workspace is not the first one you opened, it remains hinted (only on the right and on the bottom) even after being maximized by Smart Gaps.
I've recorded a short screencast to better illustrate the issue:

smart_gaps_bug.mp4

Switching to a new empty workspace and opening one or more windows gets the expected behavior back, though only on previous workspace. Here's another screencast to show this:

smart_gaps_new_workspace.mp4

(2) Steps to reproduce (if you know):

• Turn on Smart Gaps
• Open two windows or more
• Focus on the first window you opened. There should be no hint.
• Close the first window you opened, then the other windows, until only one window remains.
• The remaining window should have a hint, even though it is maximized by Smart Gaps.

(3) Expected behavior:

Same hint behavior as when Smart Gaps is turned off (first opened window is hinted normally, and maximized windows are not hinted).

(4) Distribution (run cat /etc/os-release):

NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.2 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

(5) Gnome Shell version:
3.36.9

(6) Pop Shell version (run apt policy pop-shell or provide the latest commit if building locally):

Latest commit:
4c9b6df feat(launcher): Close launcher on mouse click

(7) Where was Pop Shell installed from:
Built locally

(8) Monitor Setup (2 x 1080p, 4K, Primary(Horizontal), Secondary(Vertical), etc):
1 x 1440p Primary (Horizontal).

(9) Other Installed/Enabled Extensions:
Show Application View When Workspace Empty (bug persists if turned off)

(10) Other Notes:
My guess is that this may have to do with this commit:
8f37401 fix: enable max-state hint on multi-display only

And, of course, thank you so much for developing this amazing piece of software! My productivity has skyrocketed ever since I started using it! 🚀

[jmmaranan]

During 8f37401 - maximized, smart gapped or zero gapped should be treated the same. And if one of them is true, and you only have a single monitor display there will be no hint. If you have multiple monitors, then they would have hint when any of these maximized states (non-fullscreen) are true.

I think fixing the smart gaps (I remember it being buggy) would make the behavior a little more consistent and then can continue improving from there.