Includes p5.js as a default library. #1345
Merged
outoftime merged 2 commits intopopcodeorg:masterfrom Jan 29, 2018
demc:master
Merged
Includes p5.js as a default library. #1345outoftime merged 2 commits intopopcodeorg:masterfrom demc:master
outoftime merged 2 commits intopopcodeorg:masterfrom
demc:master
Conversation
…c300-4154-ac84-dbab2845a23c
outoftime
requested changes
Jan 26, 2018
| resolved "https://registry.yarnpkg.com/node/-/node-9.4.0.tgz#607459ecd79af0f91e74318124bec0537644cdee" | ||
| dependencies: | ||
| node-bin-setup "^1.0.0" | ||
|
|
Contributor
There was a problem hiding this comment.
I don’t think this is related to the change in question?
Author
|
Yeah that’s something goofy from my env. I’ll remove it.
… On Jan 25, 2018, at 6:45 PM, Mat Brown ***@***.*** ***@***.***>> wrote:
@outoftime requested changes on this pull request.
@demc <https://github.com/demc> Looks great to me, just appears that a stray diff in yarn.lock snuck in?
In yarn.lock <#1345 (comment)>:
> @@ -6476,6 +6480,12 @@ node-static@^0.7.9:
mime "^1.2.9"
optimist ">=0.3.4"
+node@^9.4.0:
+ version "9.4.0"
+ resolved "https://registry.yarnpkg.com/node/-/node-9.4.0.tgz#607459ecd79af0f91e74318124bec0537644cdee <https://registry.yarnpkg.com/node/-/node-9.4.0.tgz#607459ecd79af0f91e74318124bec0537644cdee>"
+ dependencies:
+ node-bin-setup "^1.0.0"
+
I don’t think this is related to the change in question?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1345 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADkjad0VTDv8ZgJuMNpgdr3wbR5DRLgRks5tOTxjgaJpZM4RttzG>.
|
Contributor
|
So cool @demc love p5! |
Author
|
Good to go? Can this go into production quickly? Thanks! |
outoftime
approved these changes
Jan 29, 2018
Contributor
|
@demc good to go! should be in production in about ~20 minutes, modulo various levels of caching |
This was referenced Feb 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a new library option for p5.js (Processing).
Since Processing relies on importing any functions in the global namespace (by design), those functions and constants have been added to the library's "predefined" list for jshint.
Try snapshot ?snapshot=61ba517e-c300-4154-ac84-dbab2845a23c