Explicitly set test NODE_ENV for running tests on Travis#1378
Merged
outoftime merged 1 commit intopopcodeorg:masterfrom Mar 4, 2018
Merged
Explicitly set test NODE_ENV for running tests on Travis#1378outoftime merged 1 commit intopopcodeorg:masterfrom
outoftime merged 1 commit intopopcodeorg:masterfrom
Conversation
outoftime
force-pushed
the
travis-node-env
branch
from
06e4236 to
be1c720
Compare
Based on exceptions that Bugsnag is reporting, it seems like the tests on Travis are being run with a `NODE_ENV` of production, even though the Karma configuration should be propagating `test` through the Webpack env plugin. Anyway, it’s probably more sensible to just explicitly set the environment variable when running tests. We do keep the env variable set to `production` for the rest of the Travis run since that’s the correct value for building the production bundle that’s going to get deployed.
outoftime
force-pushed
the
travis-node-env
branch
from
be1c720 to
f22ff05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on exceptions that Bugsnag is reporting, it seems like the tests on Travis are being run with a
NODE_ENVof production, even though the Karma configuration should be propagatingtestthrough the Webpack env plugin. Anyway, it’s probably more sensible to just explicitly set the environment variable when running tests.We do keep the env variable set to
productionfor the rest of the Travis run since that’s the correct value for building the production bundle that’s going to get deployed.