Fix peer dependency warnings#1382
Merged
outoftime merged 2 commits intopopcodeorg:masterfrom Mar 4, 2018
Merged
Conversation
added 2 commits
March 4, 2018 15:37
It’s a peer dependency of autoprefixer
Instead of pulling in the master Firebase package as a dependency, use a la carte Firebase packages for the Firebase components that we actually use—namely `@firebase/app` (the core), `@firebase/auth`, and `@firebase/database`. Also add `@firebase/app-types` as a dependency to satisfy the peer dependency of the aforementioned packages. Just requires changing the imports in the `appFirebase` service to target the individual packages, and everything seems to work just fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
yarnhas generated a bunch of warnings about peer dependencies for a little while now, which isn’t a great look. This pull request fixes them:caniuse-liteas an explicit dependency to satisfy the peer dependency ofautoprefixer@firebase/app-types, as an explicit dependency to satisfy the peer dependency of the othersThe latter change should hopefully result in a smaller bundle as well!