Upgrade loop-breaker and load it asynchronously#1383
Merged
outoftime merged 2 commits intopopcodeorg:masterfrom Mar 4, 2018
Merged
Upgrade loop-breaker and load it asynchronously#1383outoftime merged 2 commits intopopcodeorg:masterfrom
outoftime merged 2 commits intopopcodeorg:masterfrom
Conversation
Upgrades loop-breaker, which is itself upgraded to point at the latest version of `recast`, which fixes a bug with parsing certain comment nodes.
outoftime
force-pushed
the
upgrade-loop-breaker
branch
3 times, most recently
from
24be74c to
a77d6fe
Compare
Previously `loop-breaker` and its `recast` and `esprima` dependencies were loaded as part of the main bundle, which is entirely unnecessary! We only need these libraries at all if there is JavaScript to compile into the project. So, load `loop-breaker` asynchronously, and only if the project’s JavaScript source is non-empty.
outoftime
force-pushed
the
upgrade-loop-breaker
branch
from
a77d6fe to
56b4439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades loop-breaker, which is itself upgraded to point at the latest version of
recast, which fixes a bug with parsing certain comment nodes.Also, loads
loop-breakerasynchronously and only if needed, meaningrecastandesprimaare no longer part of the main bundle.Fixes #1192