Links from instructions open in a new window#1388
Merged
outoftime merged 1 commit intopopcodeorg:masterfrom Mar 13, 2018
Merged
Links from instructions open in a new window#1388outoftime merged 1 commit intopopcodeorg:masterfrom
outoftime merged 1 commit intopopcodeorg:masterfrom
Conversation
Runs instructions markdown through `remark-external-links`, which by default adds a `target="_blank"` and `rel="noopener noreferrer"` to anchor tags. At this point this is hard-coded into the `toReact` method used here, with no option to disable it—could always make it optional in the future, but it’s hard to imagine a situation in which we wouldn’t want links from processed Markdown to open in a new window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs instructions markdown through
remark-external-links, which by default adds atarget="_blank"andrel="noopener noreferrer"to anchor tags.At this point this is hard-coded into the
toReactmethod used here, with no option to disable it—could always make it optional in the future, but it’s hard to imagine a situation in which we wouldn’t want links from processed Markdown to open in a new window.