Offline access#892
Merged
outoftime merged 3 commits intopopcodeorg:masterfrom Jul 9, 2017
Merged
Conversation
Contributor
Author
|
@quixotically hey, this is working now! the major hurdle was actually that we were serving compiled assets (including everything built by Webpack) from the let me know what you think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #860, installing the Webpack
offline-pluginto allow offline access to Popcode.Pretty simple integration. One thing I don’t love is listing out all the fonts/images directly, but other than parsing the CSS I don’t have a great idea for how to keep that deduplicated.
Closes #860
Fixes #315