Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the Docker build process for Talos images by simplifying bcftools/htslib build steps, reducing redundant package installs, and switching the image version marker from ENV VERSION to ARG VERSION for CI tagging.
Changes:
- Adjust bcftools/htslib build to avoid a redundant standalone htslib download and install tabix/bgzip via the bundled htslib.
- Simplify package installation and echtvar download steps in Dockerfiles.
- Update CI version extraction to parse
ARG VERSION=...instead ofENV VERSION=....
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
src/talos/cpg_internal_scripts/CPG_Dockerfile |
Updates build stages and dependency installation for the CPG internal Talos image. |
Dockerfile |
Updates the general Talos image build (bcftools build + python deps via uv). |
.github/workflows/get_version.py |
Updates version parsing logic to match ARG VERSION in Dockerfile(s). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MattWellie
added a commit
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes
ENV VERSIONforARG VERSION- this isn't really meaningful here as we're currently using the Dockerfile line and a regular expression to extract the version value to make a build tag. If we do use this in future, an ENV variable can be changed during the build process, an ARG variable can't.Extension plans
A more meaningful/beneficial change would be to split the dockerfiles into Tools and Talos. There are no nextflow or Hail Batch stages which require both Talos code and CLI tools, and the vast majority of docker build time is rebuilding bcftools from scratch each time the cache is invalidated.
A skinny image, featuring bcftools and echtvar, would be used during the preparation steps. The Talos image would be used for the final workflow. Both can be maintained separately, i.e. the tools image may never need updating, and the Talos image would build quickly.
Currently being tested locally