-
Notifications
You must be signed in to change notification settings - Fork 331
Connection lifetime #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection lifetime #206
Conversation
* Minor docs and code style improvements
|
@iby Actually, it's about an OOM issue I hit with PostgreSQL as one of the services was making a lot of specific queries and crashing the database server. It might work for that case as well, but the connection lifetime is set using time duration and not number of requests. The issue is about how Linux's fork() and memory CoW work. It is better explained here: https://italux.medium.com/postgresql-out-of-memory-3fc1105446d |
|
I am trying to run all the tests, but the test runner is broken on my setup. I have just ensured that my new tests are running fine. My test setup: Edit. I have some new thoughts.
Let me know what you think about that. |
|
We are switching DB, so I don't think I would be able to maintain my change here, thus I will just close the MR. |
Rationale.
In order to mitigate the issue of long running connections that increase database memory usage over time I have introduced lifetime to all connections of the pool. I need your feedback on the patch.