fix: move text/plain inherit-formatting to deserialize.data#2425
Merged
christianhg merged 1 commit intomainfrom Mar 29, 2026
Merged
fix: move text/plain inherit-formatting to deserialize.data#2425christianhg merged 1 commit intomainfrom
text/plain inherit-formatting to deserialize.data#2425christianhg merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: b128e21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (86bc047) |
|---|---|---|
| Internal (raw) | 760.8 KB | +515 B, +0.1% |
| Internal (gzip) | 143.0 KB | +58 B, +0.0% |
| Bundled (raw) | 1.37 MB | +521 B, +0.0% |
| Bundled (gzip) | 305.9 KB | +61 B, +0.0% |
| Import time | 100ms | +2ms, +2.0% |
@portabletext/editor/behaviors
| Metric | Value | vs main (86bc047) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 6ms | +0ms, +0.9% |
@portabletext/editor/plugins
| Metric | Value | vs main (86bc047) |
|---|---|---|
| Internal (raw) | 2.5 KB | - |
| Internal (gzip) | 910 B | - |
| Bundled (raw) | 2.3 KB | - |
| Bundled (gzip) | 839 B | - |
| Import time | 12ms | +0ms, +1.1% |
@portabletext/editor/selectors
| Metric | Value | vs main (86bc047) |
|---|---|---|
| Internal (raw) | 60.5 KB | - |
| Internal (gzip) | 9.5 KB | - |
| Bundled (raw) | 56.9 KB | - |
| Bundled (gzip) | 8.7 KB | - |
| Import time | 10ms | +0ms, +1.7% |
@portabletext/editor/utils
| Metric | Value | vs main (86bc047) |
|---|---|---|
| Internal (raw) | 24.2 KB | - |
| Internal (gzip) | 4.7 KB | - |
| Bundled (raw) | 22.2 KB | - |
| Bundled (gzip) | 4.4 KB | - |
| Import time | 9ms | +0ms, +1.1% |
🗺️ . · ./behaviors · ./plugins · ./selectors · ./utils · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
christianhg
force-pushed
the
feat/text-plain-deserialize-data
branch
from
4409b25 to
b128e21
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
text/plaininherit-formatting behavior previously ran ondeserialization.success, which meant it intercepted and stripped structure from any blocks produced by consumerdeserialize.databehaviors. A consumer hooking intodeserialize.datato parse markdown from the clipboard and produce rich blocks (headings, code blocks, etc.) would have those blocks reduced to plain text runs because thedeserialization.successhandler only kept text from text blocks.This moves the inherit-formatting logic up to
deserialize.data, where it runs the converter inline and extracts text runs in the guard. The key ordering change: the text/plain inherit-formatting behavior is now adeserialize.databehavior that sits below consumerBehaviorPluginbehaviors in priority. When a consumer behavior matchesdeserialize.datafortext/plain, it runs first and raisesdeserialization.successwith its rich blocks. The abstract text/plain behavior never fires. When no consumer behavior matches, the abstract behavior handles it the same as before — extracting text runs and inserting spans with active decorators.The
deserialization.successhandler is now a simple passthrough toinsert.blocksfor all mime types.