fix: unify internal selection normalization#2483
Merged
christianhg merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 0552fb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (3201611) |
|---|---|---|
| Internal (raw) | 762.5 KB | -2.9 KB, -0.4% |
| Internal (gzip) | 144.2 KB | -492 B, -0.3% |
| Bundled (raw) | 1.36 MB | -2.9 KB, -0.2% |
| Bundled (gzip) | 304.9 KB | -270 B, -0.1% |
| Import time | 94ms | -1ms, -1.4% |
@portabletext/editor/behaviors
| Metric | Value | vs main (3201611) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 2ms | -0ms, -1.3% |
@portabletext/editor/plugins
| Metric | Value | vs main (3201611) |
|---|---|---|
| Internal (raw) | 2.5 KB | - |
| Internal (gzip) | 910 B | - |
| Bundled (raw) | 2.3 KB | - |
| Bundled (gzip) | 839 B | - |
| Import time | 8ms | -0ms, -1.5% |
@portabletext/editor/selectors
| Metric | Value | vs main (3201611) |
|---|---|---|
| Internal (raw) | 60.5 KB | - |
| Internal (gzip) | 9.5 KB | -9 B, -0.1% |
| Bundled (raw) | 56.9 KB | - |
| Bundled (gzip) | 8.7 KB | -1 B, -0.0% |
| Import time | 6ms | -0ms, -2.3% |
@portabletext/editor/utils
| Metric | Value | vs main (3201611) |
|---|---|---|
| Internal (raw) | 24.2 KB | - |
| Internal (gzip) | 4.7 KB | -3 B, -0.1% |
| Bundled (raw) | 22.2 KB | - |
| Bundled (gzip) | 4.4 KB | -4 B, -0.1% |
| Import time | 5ms | -0ms, -3.2% |
🗺️ . · ./behaviors · ./plugins · ./selectors · ./utils · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
319c02a to
cd667b8
Compare
toSlateRange with resolveSelectiona961273 to
3201611
Compare
c46a9f4 to
9138c07
Compare
9138c07 to
0552fb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toSlateRangeexisted to normalize selection points: resolving block-level paths to span-level paths, recovering from missing children, and clamping offsets. After the keyed paths refactor, the type conversion aspect was meaningless sinceEditorSelectionandRangeare structurally identical. The function was really just selection normalization wrapped in a misleading name.This replaces it with
resolveSelection(editor, selection)inapply-selection.ts. Every call site goes from 8 lines of snapshot assembly boilerplate to a single function call.The core
resolveSelectionPointfunction is rewritten to usegetNodeandgetLeafinstead of manual depth-2 path reconstruction. This makes it work at any depth, including inside containers:getNoderesolves the path to a real node in the treeblockOffsetToSpanSelectionPointresolves to the exact span positiongetLeafdescends to the nearest leaf childNo container special case needed.
getNodeandgetLeafare already depth-agnostic throughgetChildren.The DOM bridge function (
DOMEditor.toSlateRange/ReactEditor.toSlateRange) is unrelated and unchanged.