fix: change editableTypes from Set to Map with resolved field objects#2490
Merged
christianhg merged 1 commit intomainfrom Apr 10, 2026
Merged
fix: change editableTypes from Set to Map with resolved field objects#2490christianhg merged 1 commit intomainfrom
editableTypes from Set to Map with resolved field objects#2490christianhg merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 4304a45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (6e1e9ba) |
|---|---|---|
| Internal (raw) | 760.4 KB | -2.1 KB, -0.3% |
| Internal (gzip) | 143.8 KB | -367 B, -0.2% |
| Bundled (raw) | 1.35 MB | -2.1 KB, -0.1% |
| Bundled (gzip) | 304.5 KB | -392 B, -0.1% |
| Import time | 96ms | +1ms, +0.9% |
@portabletext/editor/behaviors
| Metric | Value | vs main (6e1e9ba) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 3ms | +0ms, +1.2% |
@portabletext/editor/plugins
| Metric | Value | vs main (6e1e9ba) |
|---|---|---|
| Internal (raw) | 2.5 KB | - |
| Internal (gzip) | 910 B | - |
| Bundled (raw) | 2.3 KB | - |
| Bundled (gzip) | 839 B | - |
| Import time | 8ms | +0ms, +1.0% |
@portabletext/editor/selectors
| Metric | Value | vs main (6e1e9ba) |
|---|---|---|
| Internal (raw) | 60.5 KB | - |
| Internal (gzip) | 9.5 KB | - |
| Bundled (raw) | 56.9 KB | - |
| Bundled (gzip) | 8.7 KB | - |
| Import time | 6ms | +0ms, +0.7% |
@portabletext/editor/utils
| Metric | Value | vs main (6e1e9ba) |
|---|---|---|
| Internal (raw) | 24.2 KB | - |
| Internal (gzip) | 4.7 KB | - |
| Bundled (raw) | 22.2 KB | - |
| Bundled (gzip) | 4.4 KB | - |
| Import time | 6ms | +0ms, +0.9% |
🗺️ . · ./behaviors · ./plugins · ./selectors · ./utils · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
a2c7255 to
f860449
Compare
f860449 to
0db631e
Compare
0db631e to
f71c1c3
Compare
f71c1c3 to
761d6b5
Compare
761d6b5 to
84889fa
Compare
84889fa to
bbc6d21
Compare
d1ef609 to
4f696a7
Compare
4f696a7 to
992c898
Compare
992c898 to
a8d68b0
Compare
a8d68b0 to
3861ef2
Compare
3861ef2 to
97739a1
Compare
…string>>` The map key is the scoped type name and the value is an array of editable field names. This prepares for explicit field declaration in the renderer API, where consumers declare which fields are editable instead of relying on the "first array field" convention. Map values are empty arrays for now. The renderer API will populate them with field names when it lands.
97739a1 to
4304a45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container rendering pipeline needs to know which fields inside a container are editable, not just whether a type is editable. Today
editableTypesis aSet<string>that only answers "is this type editable?" This forces every call site to re-walk the schema to find the actual array field definition.This changes
editableTypesto aMap<string, Array<ChildArrayField>>where the key is the scoped type name (e.g.,'code','table.row.cell') and the value is the fully resolved array field definitions (withnameandofscope).A new
resolveEditableTypes(schema, renderers)function walks the schema once at renderer registration time and returns the complete Map. Every call site that previously needed a schema walk now does a direct Map lookup:This eliminates
resolveEditableField,resolveNamedArrayField,resolveChildArrayField, andgetEditableTypePathsas separate concepts. It also removes thescopeparameter that was threaded throughgetNodeChildrenand its 10+ callers (modify.ts,is-leaf.ts,get-node.ts,get-child-field-name.ts,get-children.ts). The scope chain existed solely to feed into the runtime schema walk, which no longer happens.modify.tsfunctions (modifyDescendant,modifyChildren,modifyLeaf) now takeEditordirectly instead ofEditor | NodewithschemaandeditableTypesas separate parameters. The only caller isapply-operation.tswhich always passes the editor, so theisEditorchecks andnew Map()fallbacks were dead code.editable-types.tsowns the full concept: theEditableTypestype, theChildArrayFieldtype, and theresolveEditableTypesfunction that produces the Map from a schema and renderer set.