fix(editor): simplify globalScope to globalThis and inline at its one call site#2647
Merged
Conversation
`getGlobalScope` had a chain - `globalThis` first, then `window`, `self`, `global`. `globalThis` is universal in every environment the editor supports (browsers, Node 12+, workers, Deno, Bun), so the rest of the chain is unreachable. Beyond being dead, the `global` branch needs `@types/node` in scope to type-check. Consumers whose tsconfig doesn't pull Node types - any app that aliases `@portabletext/editor` directly to its `src/` - tripped on it. Simplify to a single `globalThis` read.
🦋 Changeset detectedLatest commit: 32a52a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (52da58b) |
|---|---|---|
| Internal (raw) | 745.0 KB | +874 B, +0.1% |
| Internal (gzip) | 142.9 KB | +109 B, +0.1% |
| Bundled (raw) | 1.35 MB | +874 B, +0.1% |
| Bundled (gzip) | 303.9 KB | +122 B, +0.0% |
| Import time | 97ms | -0ms, -0.0% |
@portabletext/editor/behaviors
| Metric | Value | vs main (52da58b) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 3ms | +0ms, +2.0% |
@portabletext/editor/plugins
| Metric | Value | vs main (52da58b) |
|---|---|---|
| Internal (raw) | 3.3 KB | -307 B, -8.4% |
| Internal (gzip) | 948 B | -73 B, -7.1% |
| Bundled (raw) | 3.1 KB | -307 B, -8.9% |
| Bundled (gzip) | 878 B | -74 B, -7.8% |
| Import time | 8ms | -0ms, -2.5% |
@portabletext/editor/selectors
| Metric | Value | vs main (52da58b) |
|---|---|---|
| Internal (raw) | 76.3 KB | - |
| Internal (gzip) | 14.3 KB | - |
| Bundled (raw) | 72.4 KB | - |
| Bundled (gzip) | 13.3 KB | - |
| Import time | 8ms | -0ms, -1.2% |
@portabletext/editor/traversal
| Metric | Value | vs main (52da58b) |
|---|---|---|
| Internal (raw) | 9.2 KB | - |
| Internal (gzip) | 2.4 KB | - |
| Bundled (raw) | 9.3 KB | - |
| Bundled (gzip) | 2.4 KB | - |
| Import time | 5ms | -0ms, -0.1% |
@portabletext/editor/utils
| Metric | Value | vs main (52da58b) |
|---|---|---|
| Internal (raw) | 30.6 KB | - |
| Internal (gzip) | 6.5 KB | - |
| Bundled (raw) | 28.4 KB | - |
| Bundled (gzip) | 6.1 KB | - |
| Import time | 7ms | +0ms, +2.1% |
🗺️ . · ./behaviors · ./plugins · ./selectors · ./traversal · ./utils · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
…and delete the dead `global-scope` helper With the Node `global` fallback gone, `global-scope.ts` is a one-line passthrough whose only job is to suppress symbol-indexing on `globalThis` with `as any`. The wrapper has nothing left to wrap. Inline the cast at the single call site in `createGloballyScopedContext` and delete the file. No public API, no behaviour change.
christianhg
changed the title
global fallback in globalScopeglobalScope to globalThis and inline at its one call site
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getGlobalScopehad a four-branch chain -globalThisfirst, thenwindow,self,global.globalThisis universal in every environment the editor supports (browsers, Node 12+, workers, Deno, Bun), so the rest of the chain is unreachable.Beyond being dead code, the
globalbranch needs@types/nodein scope to type-check. Consumers whose tsconfig doesn't pull Node types - any app that aliases@portabletext/editordirectly to itssrc/rather than going through the builtlib/- trip on it. The racetrack app atapps/racetrack/(PR #2646) ran into it on Vercel where deps build from scratch and stale tsbuildinfo caches don't hide it.With the four-branch fallback gone,
global-scope.tsis a one-line passthrough whose only job is to suppress symbol-indexing onglobalThiswithas any. There's nothing left to wrap. Inline the cast at the one call site increateGloballyScopedContextand delete the file.No public API change, no behaviour change.