Obsolete and Remove Ruby Uninstaller Deprecated Upstream#2
Open
RandomDSdevel wants to merge 1 commit intoportage-brew:masterfrom
Open
Conversation
RandomDSdevel
added a commit
to RandomDSdevel/install
that referenced
this pull request
Nov 9, 2021
…' into staging
Preview merging portage-brew#2.
RandomDSdevel
force-pushed
the
obsolete-and-remove-deprecated-scripts/Ruby-uninstaller
branch
from
b2b7815 to
6c5e118
Compare
Upstream deprecated this uninstaller script in commits `2680637`, `c6160cd`, `135edd1`, `a8104cf`, and `e690a46` after porting it to `bash` as part of Homebrew#256. We here downstream don't need to make as many backward-compatibility promises ourselves.
RandomDSdevel
added a commit
to RandomDSdevel/install
that referenced
this pull request
Nov 13, 2021
…' into staging
Preview merging portage-brew#2.
RandomDSdevel
force-pushed
the
obsolete-and-remove-deprecated-scripts/Ruby-uninstaller
branch
from
6c5e118 to
84a591d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to keep it.
See also: #1.
(Note:
This PR and #1 could technically get merged in either order, but I'd like to merge this PR second anyway since an uninstaller goes semantically after an installer.)