fix: fully-qualified image references and local-path-provisioner OOM fixFix/bug fixes#115
Merged
stevensbkang merged 2 commits intoportainer:developfrom Mar 17, 2026
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019cc917-a21f-70be-b5b8-8bd5ab39a099 Co-authored-by: Amp <amp@ampcode.com>
Bumped memory limit from 20Mi to 128Mi and request from 20Mi to 32Mi. The 20Mi limit was too low, causing kernel OOM kills under normal operation. Amp-Thread-ID: https://ampcode.com/threads/T-019cccd3-8d6e-70ce-aa87-ac6b86aa4233 Co-authored-by: Amp <amp@ampcode.com>
stevensbkang
requested review from
stevensbkang
and removed request for
deviantony
stevensbkang
approved these changes
Mar 17, 2026
Member
stevensbkang
left a comment
stevensbkang
left a comment
There was a problem hiding this comment.
LGTM! Thanks so much for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two small, independent bug fixes:
1. Use fully-qualified
docker.io/image referencesProblem: Image constants use short names (e.g.,
portainer/pause:latest) which fail on containerd runtimes that don't default todocker.ioas the registry (containerd requires fully-qualified references unlike Docker).Fix: Prefix all image constants with
docker.io/intypes/const.go.2. Increase local-path-provisioner memory limits
Problem: The memory limit of
20Miis too low — the provisioner gets OOM-killed by the kernel under normal operation, causing persistent volume claims to hang indefinitely.Fix: Bump memory limit from
20Mi→128Miand request from20Mi→32Mi. These values are consistent with the upstream local-path-provisioner defaults.Files Changed
types/const.go— Adddocker.io/prefix to 4 image constantspkg/components/localpath/deployment.go— Update memory limit/requestTesting