fix: resolve compatibility issues with photon-core 1.2.0 and AI APIs#12
Merged
Arul- merged 1 commit intoportel-dev:mainfrom Jan 17, 2026
Merged
fix: resolve compatibility issues with photon-core 1.2.0 and AI APIs#12Arul- merged 1 commit intoportel-dev:mainfrom
Arul- merged 1 commit intoportel-dev:mainfrom
Conversation
- Fix depth parameter enum compatibility issue for Gemini and other AI APIs - Remove enum constraint from number type parameter - Keep type: 'number' and clear description for valid values - Fix @portel/photon-core@1.2.0 breaking changes - Localize MCP client types removed from photon-core - Add MCPClientFactory, MCPClient, MCPTransport interfaces locally - Add MCPClientImpl class implementation - Update imports in photon-adapter.ts and photon-loader.ts - Enhance CLAUDE.md with development documentation - Add quick reference for common commands - Document dual entry point architecture - Add core component relationship diagram - Add directory structure overview - Document Photon runtime workflow 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
LGTM! This PR fixes the build failures caused by @portel/photon-core@1.2.0 removing the MCP client types. The localized type definitions look correct and match the expected interfaces. Merging to unblock CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
depthparameter enum compatibility issue for Gemini and other AI APIsChanges
1. Fix AI API Compatibility Issue
enumvalues to be strings, but thedepthparameter hadtype: 'number'withenum: [0, 1, 2]enumconstraint, keeptype: 'number'and clear descriptionsrc/server/mcp-server.ts2. Fix @portel/photon-core@1.2.0 Breaking Changes
@portel/photon-core@1.2.0removed MCP client-related types to separate concernsmcp-client-factory.tsMCPClientFactory,MCPClient,MCPTransportinterfacesMCPClientImplclass implementationphoton-adapter.tsandphoton-loader.tssrc/internal-mcps/mcp-client-factory.tssrc/internal-mcps/photon-adapter.tssrc/internal-mcps/photon-loader.ts3. Enhance Development Documentation
CLAUDE.mdTest Results
✅ Build successful
✅ All TypeScript compilation errors resolved
✅ Local testing with
npm linkworkingChecklist
npm run test)npm run test:integrationANDnpm run test:integration:dxt)npm run build && node tests/integration/comprehensive-dxt-test.cjs)src/index-mcp.ts, did I verifyawait server.run()is present?notifications/initialized?🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com