Skip to content

Add implementation fields to kernel_info_reply#1094

Merged
DavisVaughan merged 4 commits intoposit-dev:mainfrom
bjanssen:fix/kernel-info-implementation
Mar 10, 2026
Merged

Add implementation fields to kernel_info_reply#1094
DavisVaughan merged 4 commits intoposit-dev:mainfrom
bjanssen:fix/kernel-info-implementation

Conversation

@bjanssen
Copy link
Copy Markdown
Contributor

Fix Zed REPL: Ark kernel_info_reply was missing implementation and implementation_version fields, causing strict clients (Zed) to fail deserialization.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 10, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@DavisVaughan
Copy link
Copy Markdown
Contributor

A close read of https://jupyter-client.readthedocs.io/en/latest/messaging.html#kernel-info suggests two things:

  • These are indeed the 2 fields we are missing from the version 5.0 kernel_info_reply, and I have confirmed we are not missing any others

  • I do not believe these fields are optional. I believe they are required. If they were optional then this would be a Zed bug IMO. So I would advocate for making them unconditionally required.

@bjanssen
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@bjanssen
Copy link
Copy Markdown
Contributor Author

A close read of https://jupyter-client.readthedocs.io/en/latest/messaging.html#kernel-info suggests two things:

* These are indeed the 2 fields we are missing from the version 5.0 `kernel_info_reply`, and I have confirmed we are not missing any others

* I do not believe these fields are optional. I believe they are required. If they were optional then this would be a Zed bug IMO. So I would advocate for making them unconditionally required.

I agree, removed optionality.

@DavisVaughan
Copy link
Copy Markdown
Contributor

Thanks @bjanssen, we'll take it from here!

@DavisVaughan DavisVaughan merged commit 5110afd into posit-dev:main Mar 10, 2026
1 check passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants