Skip to content

Update action-gh-release to v3#1248

Open
timtmok wants to merge 1 commit into
mainfrom
1247-update-action-gh-release
Open

Update action-gh-release to v3#1248
timtmok wants to merge 1 commit into
mainfrom
1247-update-action-gh-release

Conversation

@timtmok
Copy link
Copy Markdown
Contributor

@timtmok timtmok commented May 29, 2026

Fixes #1247

Maintenance to support node.js v24

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: 1password/load-secrets-action@v3, aws-actions/configure-aws-credentials@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

We will need to update to continue using the runner. There's also setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true but that won't work on September 16, 2026.

This was addressed in Positron with https://github.com/posit-dev/positron-builds/pull/1018

Maintenance to support node.js v24
@timtmok timtmok requested a review from DavisVaughan May 29, 2026 18:21
Copy link
Copy Markdown
Contributor

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one comment


- name: Upload macOS release artifact (arm64)
uses: softprops/action-gh-release@v2
uses: softprops/action-gh-release@v3.0.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont see any reason to lock ourselves to v3.0.0, can we just use the sliding v3 tag instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Positron had previously locked to v2.0.5 since an update had regressed in some functionality (unable to update assets in a release). I think it'll be good to stick with a version we know works until we have a reason to update.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the flip side any bugs that are fixed won't flow through to us (particularly anything security related).

But sure, I don't care too much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump action-gh-release to v3

2 participants