Resolve names to all their candidate definitions#1259
Open
lionel- wants to merge 4 commits into
Open
Conversation
This was referenced Jun 5, 2026
lionel-
force-pushed
the
oak/salsa-21-multi-target
branch
from
88e8c56 to
3bba52f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #1258
Progress towards #1212
Symbol resolvers that don't take cursor offsets (
File::resolve(),resolve_at(), etc) now return all potential candidates, rather than the last one. The goto-def, find-refs, and rename handlers now offer all of them.Candidates come back in definition order, with R's runtime winner (last assignment wins) as the last element, and that order is preserved across
source()imports.A top-level
<<-now records a single file-scope definition carrying bothIS_SUPER_BOUNDandIS_BOUND,rather than a marker plus a same-scope target. At file scope there's no enclosing frame to walk to, so the two coincide. This avoids a spurious duplicate candidate.