(4) Wire up the production SourceHandler in the LSP#1301
Open
DavisVaughan wants to merge 3 commits into
Open
Conversation
lionel-
approved these changes
Jul 2, 2026
Comment on lines
+614
to
+617
| if !cfg!(debug_assertions) { | ||
| // TODO!: Remove this to activate in release builds as well. | ||
| // Currently only active in debug builds (including unit and integration tests). | ||
| return None; |
Contributor
There was a problem hiding this comment.
Since we're now at the start of the release cycle I think we can remove this, so that daily build users get exposed to this new feature?
Comment on lines
+67
to
+69
| .get_r(version) | ||
| .or_else(|| self.source.insert_r(version)) | ||
| .map(|root| SourceResponse::Success(r_dir_for_base(&root, name))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1234
Branched from #1300
This PR is most of the point of this series
The main point is that the source downloading is still off by default in release builds, but is on in debug builds (including unit and integration tests).