Increase test timeout from 1s -> 10s #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Is the world just slow today? Lots of fun with timeouts, unrelated to nextest. But these also look like false alarms so I'll just up these too. |
Again, the test is not about speed, it's just about blowing up at some point when it looks like we are really hung
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
lionel-
approved these changes
Jan 27, 2025
crates/ark/tests/data_explorer.rs
Outdated
| // Wait for the new comm to show up. | ||
| let msg = comm_manager_rx | ||
| .recv_timeout(std::time::Duration::from_secs(1)) | ||
| .recv_timeout(std::time::Duration::from_secs(10)) |
Contributor
There was a problem hiding this comment.
Probably worth using a named constant?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been exploring nextest a bit for ark, and I would get some consistent false positive timeouts with a 1s timeout. I think having multiple processes running at once causes some kind of contention, so we need a longer timeout. With this one change (and after #669) I can run
cargo nextest runon my mac without any issues.I don't think having a big timeout here is that big a deal, we aren't trying to ensure its fast, we just dont want it to get hung.
I would really like to look into nextest as I think it will help us simplify our test infra quite a bit (no management of locks or global state or needing to worry about not cross contaminating the test R session, because each test gets its own R session). It looks like we can just switch to it if we want to with little extra effort, then start simplifying