Data Explorer: Implement sort-columns-by-type feature #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements sort-columns-by-type functionality for the data explorer schema search feature. It extends the existing sorting capabilities to include type-based sorting alongside the existing name-based sorting options.
Key Changes
- Updated
SearchSchemaSortOrderenum to include four distinct sorting options: ascending/descending by name and ascending/descending by type - Enhanced search schema implementation to support type-based sorting using case-insensitive type name comparison
- Expanded test coverage with comprehensive test cases for all sorting scenarios, edge cases, and combined filters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/amalthea/src/comm/data_explorer_comm.rs |
Updated SearchSchemaSortOrder enum with granular sorting options and improved documentation |
crates/ark/src/data_explorer/r_data_explorer.rs |
Implemented type-based sorting logic with case-insensitive comparison in the search schema method |
crates/ark/tests/data_explorer.rs |
Added comprehensive test coverage for new sorting functionality and updated existing tests to use new enum variants |
Comment on lines
+24
to
+25
| /// The column indices that match the search parameters in the indicated | ||
| /// sort order. |
There was a problem hiding this comment.
[nitpick] The comment formatting is inconsistent. Use consistent indentation with spaces instead of tabs for comments to match the surrounding code style.
Suggested change
| /// The column indices that match the search parameters in the indicated | |
| /// sort order. | |
| /// The column indices that match the search parameters in the indicated | |
| /// sort order. |
Contributor
Author
There was a problem hiding this comment.
This is auto-generated code, perhaps we should change the generate-comms.ts to indent with spaces instead of tabs
lionel-
approved these changes
Aug 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the R side of posit-dev/positron#8911