Key by Url instead of Path in workspace indexer
#910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 70eb9bbfa4861b532fb9df73cced00b131b2aff8.
DavisVaughan
approved these changes
Aug 27, 2025
Contributor
DavisVaughan
left a comment
DavisVaughan
left a comment
There was a problem hiding this comment.
I like the idea but have a few questions about behavior change (maybe it needs a test?) and some efficiency things
crates/ark/src/lsp/indexer.rs
Outdated
| // Only index R files for file URIs. This discards `inmemory` (Console) and | ||
| // `ark` schemes in particular. | ||
|
|
||
| log::error!("=== Creating index for URI: {uri:?}"); |
Contributor
There was a problem hiding this comment.
Suggested change
| log::error!("=== Creating index for URI: {uri:?}"); | |
| log::trace!("Creating index for URI: {uri:?}"); |
😞
Contributor
Author
There was a problem hiding this comment.
This is a debug printf of mine, not AI slop :P
Contributor
There was a problem hiding this comment.
i appreciate you keeping me on my toes 😆
Contributor
Author
There was a problem hiding this comment.
Thanks for catching things I no longer see in diffs after working on a PR for a while...
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#8790
The warnings only appear on Windows because the conversion to
Pathactually succeeds on Unixes. So we were calling `create() with non-file URIs on Unixes but not on Windows. To fix the warnings and make things more consistent, this PR:Now uses
Url(wrapped in a newFileIdstruct) as key in our map of file to indexer. This is more general and simplifies a bunch ofPathtoUrlconversions, avoiding by the same token potential warnings. TheFileIdwrapper is used for stronger internal type checking / self-documentation, but not exposed in the public API.Declines to index non-file URIs. This makes the check for
[rR]files stronger.QA Notes
Typing in the console should no longer produce warnings in logs on Windows. I haven't been able to check as I don't have access to my Windows laptop right now.