Make it clear that srcrefs is not always present
#961
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't produce any issues with `R_EvalDepth` but it seems more sound to let R reset state before evaluation
Would be hard to get right in the case of nested browser sessions
We've never supported it, so better be explicit about it. This allows us to simplify some special-casing for that question. Also set `--no-restore-data` by default for consistency.
lionel-
force-pushed
the
feature/read-srcref
branch
3 times, most recently
from
955733f to
dc8c5cb
Compare
lionel-
force-pushed
the
feature/read-srcref
branch
from
8441b97 to
fbd76e2
Compare
Contributor
|
Thanks, the other PR now does something similar. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges into #960