Open
Conversation
Collaborator
Author
|
@cpsievert this is my attempt at moving the posit-dev/ggsql#178 and posit-dev/ggsql#179 pr over. They were still marked as draft which I'm not sure is due to forgetting to update them or if you were planning on more work |
|
Hmm, how come the description is also describing posit-dev/ggsql#143? |
Collaborator
Author
|
it was obviously at the end of the day when I opened this 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From posit-dev/ggsql#178
Summary
ParseError,ValidationError,ReaderError,WriterError) subclassingValueErrorfor backwards compatibilityReaderprotocol class defining the contract for custom readers (execute_sql,register)PyReaderBridgeto passreplaceas a keyword argument, so custom readers withregister(name, df, *, replace=False)signatures work correctlyRust changes
create_exception!macros for 4 exception types +ggsql_err_to_py()mapper.map_err(...)sites updated from genericPyValueErrorto typed exceptionsPyReaderBridge.register()usescall_methodwith kwargs instead ofcall_method1From posit-dev/ggsql#179
Summary
.pyi) for the native_ggsqlextension module, enabling IDE autocompletion and type checkingdata=dict parameter onexecute()for registering temporary DataFrames that are automatically cleaned up after execution (even on error)Rust changes
data: Option<&Bound<'_, PyDict>>parameter onPyDuckDBReader.execute()and freeexecute()register_data_dict()/register_data_on_reader()helpers withtable_exists()probe to avoid unregistering pre-existing tablestry_native_readers!macro (incompatible with cleanup-before-return pattern)