Fix literal mappings#132
Merged
thomasp85 merged 1 commit intoposit-dev:mainfrom Feb 18, 2026
Merged
Conversation
teunbrand
approved these changes
Feb 18, 2026
Collaborator
teunbrand
left a comment
teunbrand
left a comment
There was a problem hiding this comment.
Yeah either this or actualising the columns after the stat is computed would make sense to me, thanks!
Collaborator
Author
|
We need to do it like this because in theory the stat might need the literal values |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #129
This PR fixes two things surfaced by #129. First it fixes the actual error. The issue was that some stats may drop everything not created by themselves and that aren't part of the grouping. The fix is straightforward as we can just add literal mapping columns to the array of grouping columns.
The second issue was the error message which showed the raw internal column names instead of the formatted ones