Merged
Conversation
Collaborator
|
I'm not fond of the name of the Earlier we discussed |
thomasp85
reviewed
Apr 7, 2026
Comment on lines
+39
to
+40
| * `'left'` or `'top'` only displays half a violin at the left side or top side. | ||
| * `'right'` or `'bottom'` only displays half a violin at the right side or bottom side. |
Collaborator
There was a problem hiding this comment.
shouldn't left and 'bottom' be synonyms? those are the two that pointing towards the low end of the scale...
Collaborator
Author
There was a problem hiding this comment.
The vegalite calculations just worked out this way, but I kinda agree that such consistency would be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR advances #139.
Apparently this was much easier than I imagined at first.
Simply messing with the mirroring creates ridgeline plots and one can use
widthto control the degree of overlap between ridges.