Conversation
georgestagg
left a comment
There was a problem hiding this comment.
LGTM.
Minor comments:
If we're vendoring the skill in doc, do we need the scheme to also fetch it at build time? Why not just always bundle the version currently on disk?
The build.rs script seems a little too dependent on our current Quarto documentation structure, I am sure it is going to break at some point as we reorganise sections. I don't have any ideas of an alternative though, so I won't block on it and we'll just deal with it when it becomes a problem.
|
Yeah, I don't think we can avoid this structural dependency since we can't in general ensure that the website organisation matches the cli api The vendoring of the skill is simply done so that build succeeds even when you are offline. It should be automatically updated when building so we always include the latest version from the source assuming we are online |
I don't know if we always want to include the latest version. If I checkout an old git tag and build a previous release I'd like the included skill to be from that time period. I personally would prefer we just bundle from the vendored version and endeavour to keep the vendored version reasonably up to date. |
|
I'm fine with that |
|
Thanks! We could even emit a link to the |
Fix #329
This PR adds documentation to the CI, compiled at built time from the website docs. These reside in under a docs command. Additionally there is a new skill command that shows the claude skill. This is fetched at runtime from the main repo and cached so that offline building still works (but might use a dated skills file)